[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201002152219.GB3875@1wt.eu>
Date: Fri, 2 Oct 2020 17:22:19 +0200
From: Willy Tarreau <w@....eu>
To: Thibaut Sautereau <thibaut.sautereau@...p-os.org>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
Kees Cook <keescook@...omium.org>, netdev@...r.kernel.org,
kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org,
Thibaut Sautereau <thibaut.sautereau@....gouv.fr>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Emese Revfy <re.emese@...il.com>
Subject: Re: [PATCH] random32: Restore __latent_entropy attribute on
net_rand_state
On Fri, Oct 02, 2020 at 05:16:11PM +0200, Thibaut Sautereau wrote:
> From: Thibaut Sautereau <thibaut.sautereau@....gouv.fr>
>
> Commit f227e3ec3b5c ("random32: update the net random state on interrupt
> and activity") broke compilation and was temporarily fixed by Linus in
> 83bdc7275e62 ("random32: remove net_rand_state from the latent entropy
> gcc plugin") by entirely moving net_rand_state out of the things handled
> by the latent_entropy GCC plugin.
>
> From what I understand when reading the plugin code, using the
> __latent_entropy attribute on a declaration was the wrong part and
> simply keeping the __latent_entropy attribute on the variable definition
> was the correct fix.
Ah thank you, this is what I tried to figure and failed to! Spender
mentioned that a one-liner was all that was needed to fix this but
never responded to my request asking about it.
Willy
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
