Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 1 Oct 2020 15:17:07 +0200 (CEST)
From: Miroslav Benes <>
To: Sami Tolvanen <>
cc: Masahiro Yamada <>, Will Deacon <>, 
    Steven Rostedt <>, 
    Peter Zijlstra <>, 
    Greg Kroah-Hartman <>, 
    "Paul E. McKenney" <>, Kees Cook <>, 
    Nick Desaulniers <>,,,,,,,,,,
Subject: Re: [PATCH v4 04/29] objtool: Add a pass for generating

Hi Sami,

On Tue, 29 Sep 2020, Sami Tolvanen wrote:

> From: Peter Zijlstra <>
> Add the --mcount option for generating __mcount_loc sections
> needed for dynamic ftrace. Using this pass requires the kernel to
> be compiled with -mfentry and CC_USING_NOP_MCOUNT to be defined
> in Makefile.
> Link:
> Signed-off-by: Peter Zijlstra <>
> [Sami: rebased to mainline, dropped config changes, fixed to actually use
>        --mcount, and wrote a commit message.]
> Signed-off-by: Sami Tolvanen <>
> Reviewed-by: Kees Cook <>

I am sorry to reply on v4. Should have been sooner.

Julien has been sending patches to make objtool's check functionality 
arch-agnostic as much as possible. So it seems to me that the patch should 
be based on the effort

I also wonder about making 'mcount' command separate from 'check'. Similar 
to what is 'orc' now. But that could be done later.

See tip-tree/objtool/core for both.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.