kernel-hardening - Re: [PATCH v3 1/2] arm64/acpi: disallow AML memory opregions to access kernel memory

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930171908.GA1732@gaia>
Date: Wed, 30 Sep 2020 18:19:08 +0100
From: Catalin Marinas <catalin.marinas@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Ard Biesheuvel <ardb@...nel.org>,
	Linux ARM <linux-arm-kernel@...ts.infradead.org>,
	"Jason A . Donenfeld" <Jason@...c4.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Kernel Hardening <kernel-hardening@...ts.openwall.com>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Sudeep Holla <sudeep.holla@....com>, Will Deacon <will@...nel.org>,
	Linuxarm <linuxarm@...wei.com>
Subject: Re: [PATCH v3 1/2] arm64/acpi: disallow AML memory opregions to
 access kernel memory

Hi Jonathan,

On Wed, Sep 30, 2020 at 10:27:22AM +0100, Jonathan Cameron wrote:
> On Tue, 29 Sep 2020 11:29:48 +0200 Ard Biesheuvel <ardb@...nel.org> wrote:
> > Could you try the patch below? Since the memory holding the tables is
> > already memblock_reserve()d, we can just mark it NOMAP, and permit r/o
> > remapping of NOMAP regions.
> 
> Looks good.  Thanks.
> 
> Tested-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Could you please try the updated patch that Ard posted. There are a few
minor differences:

https://lore.kernel.org/linux-acpi/20200929132522.18067-1-ardb@kernel.org/

Thanks.

-- 
Catalin

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.