[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200923173905.11219-11-kristen@linux.intel.com>
Date: Wed, 23 Sep 2020 10:39:04 -0700
From: Kristen Carlson Accardi <kristen@...ux.intel.com>
To: keescook@...omium.org,
tglx@...utronix.de,
mingo@...hat.com,
bp@...en8.de,
Josh Poimboeuf <jpoimboe@...hat.com>,
Jiri Kosina <jikos@...nel.org>,
Miroslav Benes <mbenes@...e.cz>,
Petr Mladek <pmladek@...e.com>,
Joe Lawrence <joe.lawrence@...hat.com>
Cc: arjan@...ux.intel.com,
x86@...nel.org,
linux-kernel@...r.kernel.org,
kernel-hardening@...ts.openwall.com,
rick.p.edgecombe@...el.com,
Kristen Carlson Accardi <kristen@...ux.intel.com>,
live-patching@...r.kernel.org
Subject: [PATCH v5 10/10] livepatch: only match unique symbols when using fgkaslr
If any type of function granular randomization is enabled, the sympos
algorithm will fail, as it will be impossible to resolve symbols when
there are duplicates using the previous symbol position.
Override the value of sympos to always be zero if fgkaslr is enabled for
either the core kernel or modules, forcing the algorithm
to require that only unique symbols are allowed to be patched.
Signed-off-by: Kristen Carlson Accardi <kristen@...ux.intel.com>
---
kernel/livepatch/core.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index f76fdb925532..da08e40f2da2 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -170,6 +170,17 @@ static int klp_find_object_symbol(const char *objname, const char *name,
kallsyms_on_each_symbol(klp_find_callback, &args);
mutex_unlock(&module_mutex);
+ /*
+ * If any type of function granular randomization is enabled, it
+ * will be impossible to resolve symbols when there are duplicates
+ * using the previous symbol position (i.e. sympos != 0). Override
+ * the value of sympos to always be zero in this case. This will
+ * force the algorithm to require that only unique symbols are
+ * allowed to be patched.
+ */
+ if (IS_ENABLED(CONFIG_FG_KASLR) || IS_ENABLED(CONFIG_MODULE_FG_KASLR))
+ sympos = 0;
+
/*
* Ensure an address was found. If sympos is 0, ensure symbol is unique;
* otherwise ensure the symbol position count matches sympos.
--
2.20.1
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
