[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200827071227.tozlhvidn3iet6xy@steredhat.lan>
Date: Thu, 27 Aug 2020 09:12:27 +0200
From: Stefano Garzarella <sgarzare@...hat.com>
To: Kees Cook <keescook@...omium.org>
Cc: Jens Axboe <axboe@...nel.dk>,
Christian Brauner <christian.brauner@...ntu.com>,
Jann Horn <jannh@...gle.com>, Jeff Moyer <jmoyer@...hat.com>,
linux-fsdevel@...r.kernel.org, Sargun Dhillon <sargun@...gun.me>,
Alexander Viro <viro@...iv.linux.org.uk>,
Kernel Hardening <kernel-hardening@...ts.openwall.com>,
Stefan Hajnoczi <stefanha@...hat.com>, linux-kernel@...r.kernel.org,
Aleksa Sarai <asarai@...e.de>, io-uring@...r.kernel.org
Subject: Re: [PATCH v4 2/3] io_uring: add IOURING_REGISTER_RESTRICTIONS opcode
On Wed, Aug 26, 2020 at 12:46:24PM -0700, Kees Cook wrote:
> On Thu, Aug 13, 2020 at 05:32:53PM +0200, Stefano Garzarella wrote:
> > +/*
> > + * io_uring_restriction->opcode values
> > + */
> > +enum {
> > + /* Allow an io_uring_register(2) opcode */
> > + IORING_RESTRICTION_REGISTER_OP,
> > +
> > + /* Allow an sqe opcode */
> > + IORING_RESTRICTION_SQE_OP,
> > +
> > + /* Allow sqe flags */
> > + IORING_RESTRICTION_SQE_FLAGS_ALLOWED,
> > +
> > + /* Require sqe flags (these flags must be set on each submission) */
> > + IORING_RESTRICTION_SQE_FLAGS_REQUIRED,
> > +
> > + IORING_RESTRICTION_LAST
> > +};
>
> Same thought on enum literals, but otherwise, looks good:
Sure, I'll fix the enum in the next version.
>
> Reviewed-by: Kees Cook <keescook@...omium.org>
Thanks for the review,
Stefano
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
