|
Message-ID: <87zh7gm471.fsf@kernel.org>
Date: Fri, 31 Jul 2020 12:20:02 +0300
From: Felipe Balbi <balbi@...nel.org>
To: Kees Cook <keescook@...omium.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Kees Cook <keescook@...omium.org>, Thomas Gleixner <tglx@...utronix.de>, Allen Pais <allen.lkml@...il.com>, Oscar Carter <oscar.carter@....com>, Romain Perier <romain.perier@...il.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Kevin Curtis <kevin.curtis@...site.co.uk>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Harald Freudenberger <freude@...ux.ibm.com>, Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ibm.com>, Jiri Slaby <jslaby@...e.com>, Jason Wessel <jason.wessel@...driver.com>, Daniel
Thompson <daniel.thompson@...aro.org>, Douglas Anderson <dianders@...omium.org>, Mitchell Blank Jr <mitch@...oth.com>, Julian
Wiedmann <jwi@...ux.ibm.com>, Karsten Graul <kgraul@...ux.ibm.com>, Ursula
Braun <ubraun@...ux.ibm.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Christian Gromm <christian.gromm@...rochip.com>, Nishka
Dasgupta <nishkadg.linux@...il.com>, Masahiro Yamada <masahiroy@...nel.org>, Stephen Boyd <swboyd@...omium.org>, "Matthew Wilcox \(Oracle\)" <willy@...radead.org>, Wambui Karuga <wambui.karugax@...il.com>, Guenter
Roeck <linux@...ck-us.net>, Chris Packham <chris.packham@...iedtelesis.co.nz>, Kyungtae Kim <kt0755@...il.com>, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Jonathan Corbet <corbet@....net>, Peter
Zijlstra <peterz@...radead.org>, Will Deacon <will@...nel.org>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-s390@...r.kernel.org, devel@...verdev.osuosl.org, linux-usb@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net, alsa-devel@...a-project.org, kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH 1/3] usb: gadget: udc: Avoid tasklet passing a global
Hi,
Kees Cook <keescook@...omium.org> writes:
> There's no reason for the tasklet callback to set an argument since it
> always uses a global. Instead, use the global directly, in preparation
> for converting the tasklet subsystem to modern callback conventions.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>
looks okay to me.
Acked-by: Felipe Balbi <balbi@...nel.org>
--
balbi
Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.