|
Message-ID: <202006240022.E5FB4E08F3@keescook> Date: Wed, 24 Jun 2020 00:25:09 -0700 From: Kees Cook <keescook@...omium.org> To: Kristen Carlson Accardi <kristen@...ux.intel.com> Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, arjan@...ux.intel.com, x86@...nel.org, linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com, rick.p.edgecombe@...el.com, Tony Luck <tony.luck@...el.com> Subject: Re: [PATCH v3 09/10] kallsyms: Hide layout On Tue, Jun 23, 2020 at 10:23:26AM -0700, Kristen Carlson Accardi wrote: > +static int kallsyms_open(struct inode *inode, struct file *file) > +{ > + int ret; > + struct list_head *list; > + > + list = __seq_open_private(file, &kallsyms_sorted_op, sizeof(*list)); > + if (!list) > + return -ENOMEM; > + > + INIT_LIST_HEAD(list); > + > + ret = kallsyms_on_each_symbol(get_all_symbol_name, list); > + if (ret != 0) > + return ret; > + > + list_sort(NULL, list, kallsyms_list_cmp); > + > + return 0; > +} Oh, wait, one thing! I think this feedback to v2 got missed: https://lore.kernel.org/lkml/202005211441.F63205B7@keescook/ This bug still exists, and has the same solution. -- Kees Cook
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.