Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d7b118c1-0369-9aef-bd34-afc9bafc7e7b@linux.com>
Date: Wed, 24 Jun 2020 16:09:20 +0300
From: Alexander Popov <alex.popov@...ux.com>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: Kees Cook <keescook@...omium.org>, Jann Horn <jannh@...gle.com>,
 Emese Revfy <re.emese@...il.com>,
 Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
 Masahiro Yamada <masahiroy@...nel.org>,
 Michal Marek <michal.lkml@...kovi.net>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Masahiro Yamada <yamada.masahiro@...ionext.com>,
 Thiago Jung Bauermann <bauerman@...ux.ibm.com>, Jessica Yu
 <jeyu@...nel.org>, Sven Schnelle <svens@...ckframe.org>,
 Iurii Zaikin <yzaikin@...gle.com>, Catalin Marinas
 <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Vincenzo Frascino <vincenzo.frascino@....com>,
 Thomas Gleixner <tglx@...utronix.de>, Peter Collingbourne <pcc@...gle.com>,
 Naohiro Aota <naohiro.aota@....com>, Alexander Monakov <amonakov@...ras.ru>,
 Mathias Krause <minipli@...glemail.com>, PaX Team <pageexec@...email.hu>,
 Brad Spengler <spender@...ecurity.net>, Laura Abbott <labbott@...hat.com>,
 Florian Weimer <fweimer@...hat.com>, kernel-hardening@...ts.openwall.com,
 linux-kbuild@...r.kernel.org, x86@...nel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 gcc@....gnu.org, notify@...nel.org
Subject: Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin
 parameter

On 24.06.2020 15:53, Luis Chamberlain wrote:
> On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote:
>> Add 'verbose' plugin parameter for stackleak gcc plugin.
>> It can be used for printing additional info about the kernel code
>> instrumentation.
>>
>> For using it add the following to scripts/Makefile.gcc-plugins:
>>   gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STACKLEAK) \
>>     += -fplugin-arg-stackleak_plugin-verbose
> 
> Would be nice if we instead could pass an argument to make which lets
> us enable this.

This feature is useful only for debugging stackleak gcc plugin.

The cflag that enables it is similar to -fplugin-arg-structleak_plugin-verbose,
which is used for debugging the structleak plugin.

This debugging feature clutters the kernel build output, I don't think that many
people will use it. So IMO creating a separate argument for make is not really
needed.

Thanks!

Best regards,
Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.