[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200618124157.0b9b8807@oasis.local.home>
Date: Thu, 18 Jun 2020 12:41:57 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Jann Horn <jannh@...gle.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...nel.org>,
Kees Cook <keescook@...omium.org>, Kernel Hardening
<kernel-hardening@...ts.openwall.com>, Oscar Carter <oscar.carter@....com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] tracing: Use linker magic instead of recasting
ftrace_ops_list_func()
On Thu, 18 Jun 2020 01:12:37 +0200
Jann Horn <jannh@...gle.com> wrote:
> static ftrace_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops)
> +static ftrace_asm_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops)
> {
> +#if FTRACE_FORCE_LIST_FUNC
> + return ftrace_ops_list_func;
> +#else
> /*
> * If this is a dynamic, RCU, or per CPU ops, or we force list func,
> * then it needs to call the list anyway.
> */
> - if (ops->flags & (FTRACE_OPS_FL_DYNAMIC | FTRACE_OPS_FL_RCU) ||
> - FTRACE_FORCE_LIST_FUNC)
> + if (ops->flags & (FTRACE_OPS_FL_DYNAMIC | FTRACE_OPS_FL_RCU))
> return ftrace_ops_list_func;
>
> return ftrace_ops_get_func(ops);
But ftrace_ops_get_func() returns ftrace_func_t type, wont this complain?
-- Steve
> +#endif
> }
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
