[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <729988fe-5f92-645c-15a0-eda0f0afbbcb@linux.com>
Date: Wed, 10 Jun 2020 18:14:51 +0300
From: Alexander Popov <alex.popov@...ux.com>
To: Kees Cook <keescook@...omium.org>
Cc: Emese Revfy <re.emese@...il.com>,
Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
Masahiro Yamada <masahiroy@...nel.org>,
Michal Marek <michal.lkml@...kovi.net>,
Andrew Morton <akpm@...ux-foundation.org>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Thiago Jung Bauermann <bauerman@...ux.ibm.com>,
Luis Chamberlain <mcgrof@...nel.org>, Jessica Yu <jeyu@...nel.org>,
Sven Schnelle <svens@...ckframe.org>, Iurii Zaikin <yzaikin@...gle.com>,
Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
Vincenzo Frascino <vincenzo.frascino@....com>,
Thomas Gleixner <tglx@...utronix.de>, Peter Collingbourne <pcc@...gle.com>,
Naohiro Aota <naohiro.aota@....com>, Alexander Monakov <amonakov@...ras.ru>,
Mathias Krause <minipli@...glemail.com>, PaX Team <pageexec@...email.hu>,
Brad Spengler <spender@...ecurity.net>, Laura Abbott <labbott@...hat.com>,
Florian Weimer <fweimer@...hat.com>, kernel-hardening@...ts.openwall.com,
linux-kbuild@...r.kernel.org, x86@...nel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
gcc@....gnu.org, notify@...nel.org
Subject: Re: [PATCH 0/5] Improvements of the stackleak gcc plugin
On 09.06.2020 22:15, Kees Cook wrote:
> On Thu, Jun 04, 2020 at 04:49:52PM +0300, Alexander Popov wrote:
>> In this patch series I collected various improvements of the stackleak
>> gcc plugin.
>
> Thanks!
>
>> Alexander Popov (5):
>> gcc-plugins/stackleak: Exclude alloca() from the instrumentation logic
>> gcc-plugins/stackleak: Use asm instrumentation to avoid useless
>> register saving
>
> These look like they might need tweaks (noted in their separate
> replies).
Thanks for the review, Kees.
>> gcc-plugins/stackleak: Add 'verbose' plugin parameter
>> gcc-plugins/stackleak: Don't instrument itself
>
> If you wanted to reorder the series and move these first, I could take
> these into my tree right away (they're logically separate from the other
> fixes).
Ok, I will put "don't instrument itself" at the beginning of v2.
The patch adding 'verbose' plugin parameter depends on the previous patches, so
I will not move it.
>> gcc-plugins/stackleak: Don't instrument vgettimeofday.c in arm64 VDSO
>
> This seems good -- though I'm curious about 32-bit ARM and the other
> HAVE_GCC_PLUGINS architectures with vDSOs (which appears to be all of
> them except um).
(going to reply in a separate email)
Best regards,
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
