[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200530143430.5203-1-oscar.carter@gmx.com>
Date: Sat, 30 May 2020 16:34:27 +0200
From: Oscar Carter <oscar.carter@....com>
To: Kees Cook <keescook@...omium.org>,
Thomas Gleixner <tglx@...utronix.de>,
Jason Cooper <jason@...edaemon.net>,
Marc Zyngier <maz@...nel.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Len Brown <lenb@...nel.org>
Cc: Oscar Carter <oscar.carter@....com>,
kernel-hardening@...ts.openwall.com,
linux-kernel@...r.kernel.org,
linux-acpi@...r.kernel.org
Subject: [PATCH v5 0/3] drivers/acpi: Remove function callback casts
In an effort to enable -Wcast-function-type in the top-level Makefile to
support Control Flow Integrity builds, there are the need to remove all
the function callback casts in the acpi driver.
The first patch creates a macro called ACPI_DECLARE_SUBTABLE_PROBE_ENTRY
to initialize the acpi_probe_entry struct using the probe_subtbl field
instead of the probe_table field to avoid function cast mismatches.
The second patch modifies the IRQCHIP_ACPI_DECLARE macro to use the new
defined macro ACPI_DECLARE_SUBTABLE_PROBE_ENTRY instead of the macro
ACPI_DECLARE_PROBE_ENTRY. Also, modifies the prototype of the functions
used by the invocation of the IRQCHIP_ACPI_DECLARE macro to match all the
parameters.
The third patch removes the function cast in the ACPI_DECLARE_PROBE_ENTRY
macro to ensure that the functions passed as a last parameter to this macro
have the right prototype. This macro is used only in another macro
called "TIMER_ACPI_DECLARE". An this is used only in the file:
drivers/clocksource/arm_arch_timer.c
In this file, the function used in the last parameter of the
TIMER_ACPI_DECLARE macro already has the right prototype. So there is no
need to modify its prototype.
Changelog v1->v2
- Add more details in the commit changelog to clarify the changes (Marc
Zyngier)
- Declare a new macro called ACPI_DECLARE_SUBTABLE_PROBE_ENTRY (Marc
Zyngier)
- In the IRQCHIP_ACPI_DECLARE use the new defined macro (Marc Zyngier)
Changelog v2->v3
- Remove the cast of the macro ACPI_DECLARE_SUBTABLE_PROBE_ENTRY (Marc
Zyngier)
- Change the prototype of the functions used by the invocation of the
macro IRQCHIP_ACPI_DECLARE (Marc Zyngier)
- Split the changes in two patches.
- Add these two lines, to give credit to Marc Zyngier
Co-developed-by: Marc Zyngier <maz@...nel.org>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Changelog v3->v4
- Add a new patch to remove the cast of the macro
ACPI_DECLARE_PROBE_ENTRY (Marc Zyngier)
- Change the subject of the first patch
Changelog v4->v5
- Add the following lines removed by error in the v4 version:
Co-developed-by: Marc Zyngier <maz@...nel.org>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Oscar Carter (3):
drivers/acpi: Add new macro ACPI_DECLARE_SUBTABLE_PROBE_ENTRY
drivers/irqchip: Use new macro ACPI_DECLARE_SUBTABLE_PROBE_ENTRY
drivers/acpi: Remove function cast
drivers/irqchip/irq-gic-v3.c | 2 +-
drivers/irqchip/irq-gic.c | 2 +-
include/linux/acpi.h | 23 +++++++++++++++++------
include/linux/irqchip.h | 5 +++--
4 files changed, 22 insertions(+), 10 deletions(-)
--
2.20.1
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
