kernel-hardening - Re: [PATCH v2] firewire: Remove function callback casts

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200523061033.GB3131938@kroah.com>
Date: Sat, 23 May 2020 08:10:33 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Oscar Carter <oscar.carter@....com>
Cc: stable <stable@...r.kernel.org>,
	Takashi Sakamoto <o-takashi@...amocchi.jp>,
	Kees Cook <keescook@...omium.org>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Clemens Ladisch <clemens@...isch.de>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	kernel-hardening@...ts.openwall.com,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, alsa-devel@...a-project.org,
	"Lev R . Oshvang ." <levonshe@...il.com>
Subject: Re: [PATCH v2] firewire: Remove function callback casts

On Fri, May 22, 2020 at 07:43:08PM +0200, Oscar Carter wrote:
> Hi,
> 
> On Wed, May 20, 2020 at 03:16:24PM +0900, Takashi Sakamoto wrote:
> > Hi,
> >
> > I'm an author of ALSA firewire stack and thanks for the patch. I agree with
> > your intention to remove the cast of function callback toward CFI build.
> >
> > Practically, the isochronous context with FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL
> > is never used by in-kernel drivers. Here, I propose to leave current
> > kernel API (fw_iso_context_create() with fw_iso_callback_t) as is.

If it's not used by anyone, why is it still there?  Can't we just delete
it?

thanks,

greg k-h

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.