kernel-hardening - Re: [PATCH] firewire: Remove function callback casts

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200519165910.GA3187@ubuntu>
Date: Tue, 19 May 2020 18:59:11 +0200
From: Oscar Carter <oscar.carter@....com>
To: "Lev R. Oshvang ." <levonshe@...il.com>
Cc: Oscar Carter <oscar.carter@....com>, Kees Cook <keescook@...omium.org>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Clemens Ladisch <clemens@...isch.de>,
	Takashi Sakamoto <o-takashi@...amocchi.jp>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	kernel-hardening@...ts.openwall.com,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH] firewire: Remove function callback casts

On Sun, May 17, 2020 at 07:43:21PM +0300, Lev R. Oshvang . wrote:
>
> Hi Oscar,
> I would recommend to explicitly set NULL to _cb and use if elif to
> exclude the case where botm _cb paraneters are passed as NULLs :
> > +
>   ctx->callback.mc =NULL:
>   ctx->callback.sc = NULL;
> > +       if (cb_sc)
> > +               ctx->callback.sc = cb_sc;
>
> > +       elif (cb_ms)
> > +               ctx->callback.mc = cb_mc;
> > +         else
>                     return -EINVAL;

Ok, I will do the changes you suggested and I will resend a new version.

> Hope you get the point.
> Lev

Thanks,
Oscar Carter

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.