[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200420211201.7fea9561@oasis.local.home>
Date: Mon, 20 Apr 2020 21:12:01 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Will Deacon <will@...nel.org>
Cc: Sami Tolvanen <samitolvanen@...gle.com>, Catalin Marinas
<catalin.marinas@....com>, James Morse <james.morse@....com>, Ard
Biesheuvel <ard.biesheuvel@...aro.org>, Mark Rutland
<mark.rutland@....com>, Masahiro Yamada <masahiroy@...nel.org>, Michal
Marek <michal.lkml@...kovi.net>, Ingo Molnar <mingo@...hat.com>, Peter
Zijlstra <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>, Dave Martin
<Dave.Martin@....com>, Kees Cook <keescook@...omium.org>, Laura Abbott
<labbott@...hat.com>, Marc Zyngier <maz@...nel.org>, Masami Hiramatsu
<mhiramat@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Jann
Horn <jannh@...gle.com>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
clang-built-linux@...glegroups.com, kernel-hardening@...ts.openwall.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 01/12] add support for Clang's Shadow Call Stack
(SCS)
On Mon, 20 Apr 2020 18:17:28 +0100
Will Deacon <will@...nel.org> wrote:
> > +ifdef CONFIG_SHADOW_CALL_STACK
> > +CC_FLAGS_SCS := -fsanitize=shadow-call-stack
> > +KBUILD_CFLAGS += $(CC_FLAGS_SCS)
> > +export CC_FLAGS_SCS
> > +endif
>
> CFLAGS_SCS would seem more natural to me, although I see ftrace does it this
> way.
The CC_FLAGS_FTRACE was added by Heiko Carstens, and the "CC_FLAGS_"
appears to be a common usage in s390 :-)
That said, I like the CC_FLAGS_ notation, because the Linux build
system uses CFLAGS_* as commands:
CFLAGS_foo.o = x
CFLAGS_REMOVE_foo.o = y
And "CC_FLAGS_" is only for new flags and easy to search for.
-- Steve
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
