Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEf4Bzb2mgDPcdNGWnBgoqsuWYqDiv39U2irn4iCp=7B3kx1nA@mail.gmail.com>
Date: Thu, 2 Apr 2020 12:31:36 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Slava Bacherikov <slava@...her09.org>
Cc: Andrii Nakryiko <andriin@...com>, Kees Cook <keescook@...omium.org>, bpf <bpf@...r.kernel.org>, 
	open list <linux-kernel@...r.kernel.org>, Jann Horn <jannh@...gle.com>, 
	Alexei Starovoitov <alexei.starovoitov@...il.com>, Daniel Borkmann <daniel@...earbox.net>, 
	Kernel Hardening <kernel-hardening@...ts.openwall.com>, 
	Liu Yiding <liuyd.fnst@...fujitsu.com>, kpsingh@...gle.com
Subject: Re: [PATCH v4 bpf] kbuild: fix dependencies for DEBUG_INFO_BTF

On Thu, Apr 2, 2020 at 8:40 AM Slava Bacherikov <slava@...her09.org> wrote:
>
>
>
> 02.04.2020 18:33, Slava Bacherikov wrote:
> > +     depends on DEBUG_INFO || COMPILE_TEST
>
> Andrii are you fine by this ?

I think it needs a good comment explaining this weirdness, at least.
As I said, if there is no DEBUG_INFO, there is not point in doing
DWARF-to-BTF conversion, even more -- it actually might fail, I
haven't checked what pahole does in that case. So I'd rather drop
GCC_PLUGIN_RANDSTRUCT is that's the issue here. DEBUG_INFO_SPLIT and
DEBUG_INFO_REDUCED look good.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.