Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 31 Mar 2020 13:37:34 +0100
From: Will Deacon <>
To: "Paul E. McKenney" <>
Cc:, Eric Dumazet <>,
	Jann Horn <>, Kees Cook <>,
	Maddie Stone <>,
	Marco Elver <>,
	Peter Zijlstra <>,
	Thomas Gleixner <>,,
Subject: Re: [RFC PATCH 09/21] list: Remove unnecessary WRITE_ONCE() from

On Mon, Mar 30, 2020 at 04:30:20PM -0700, Paul E. McKenney wrote:
> On Tue, Mar 24, 2020 at 03:36:31PM +0000, Will Deacon wrote:
> > There is no need to use WRITE_ONCE() when inserting into a non-RCU
> > protected list.
> > 
> > Cc: Paul E. McKenney <>
> > Cc: Peter Zijlstra <>
> > Signed-off-by: Will Deacon <>
> OK, I will bite...  Why "unsigned long" instead of "uintptr_t"?

I just did that for consistency with the rest of the file, e.g.
hlist_bl_first(), hlist_bl_set_first(), hlist_bl_empty() and
__hlist_bl_del() all cast to 'unsigned long', yet only
hlist_bl_add_before() was using 'uintptr_t'

> Not that it matters in the context of the Linux kernel, so:
> Reviewed-by: Paul E. McKenney <>

Thanks, Paul!


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.