[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNATWkXiWtR+=eWxqxewsJjy_nvSmcByCR-ZehO95yN-c+A@mail.gmail.com>
Date: Sun, 29 Mar 2020 20:03:39 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Kees Cook <keescook@...omium.org>
Cc: Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
Kernel Hardening <kernel-hardening@...ts.openwall.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] kconfig: remove unused variable in qconf.cc
On Thu, Mar 26, 2020 at 11:06 AM Kees Cook <keescook@...omium.org> wrote:
>
> On Wed, Mar 25, 2020 at 12:14:31PM +0900, Masahiro Yamada wrote:
> > If this file were compiled with -Wall, the following warning would be
> > reported:
> >
> > scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable]
> > int i;
> > ^
> >
> > The commit prepares to turn on -Wall for C++ host programs.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>
> Reviewed-by: Kees Cook <keescook@...omium.org>
>
Applied to linux-kbuild.
> -Kees
>
> > ---
> >
> > scripts/kconfig/qconf.cc | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> > index 82773cc35d35..50a5245d87bb 100644
> > --- a/scripts/kconfig/qconf.cc
> > +++ b/scripts/kconfig/qconf.cc
> > @@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name)
> > showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt),
> > rootEntry(0), headerPopup(0)
> > {
> > - int i;
> > -
> > setObjectName(name);
> > setSortingEnabled(false);
> > setRootIsDecorated(true);
> > --
> > 2.17.1
> >
>
> --
> Kees Cook
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
