|
Message-ID: <20200328230046.v3qbffmbtl4sd7tg@comp-core-i7-2640m-0182e6> Date: Sun, 29 Mar 2020 00:00:46 +0100 From: Alexey Gladkov <gladkov.alexey@...il.com> To: Kees Cook <keescook@...omium.org> Cc: LKML <linux-kernel@...r.kernel.org>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, Linux API <linux-api@...r.kernel.org>, Linux FS Devel <linux-fsdevel@...r.kernel.org>, Linux Security Module <linux-security-module@...r.kernel.org>, Akinobu Mita <akinobu.mita@...il.com>, Alexander Viro <viro@...iv.linux.org.uk>, Alexey Dobriyan <adobriyan@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, Andy Lutomirski <luto@...nel.org>, Daniel Micay <danielmicay@...il.com>, Djalal Harouni <tixxdz@...il.com>, "Dmitry V . Levin" <ldv@...linux.org>, "Eric W . Biederman" <ebiederm@...ssion.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ingo Molnar <mingo@...nel.org>, "J . Bruce Fields" <bfields@...ldses.org>, Jeff Layton <jlayton@...chiereds.net>, Jonathan Corbet <corbet@....net>, Linus Torvalds <torvalds@...ux-foundation.org>, Oleg Nesterov <oleg@...hat.com> Subject: Re: [PATCH v10 7/9] proc: move hidepid values to uapi as they are user interface to mount On Sat, Mar 28, 2020 at 02:53:49PM -0700, Kees Cook wrote: > > > > +/* definitions for hide_pid field */ > > > > +enum { > > > > + HIDEPID_OFF = 0, > > > > + HIDEPID_NO_ACCESS = 1, > > > > + HIDEPID_INVISIBLE = 2, > > > > + HIDEPID_NOT_PTRACEABLE = 4, > > > > +}; > > > Should the numeric values still be UAPI if there is string parsing now? > > > > I think yes, because these are still valid hidepid= values. > > But if we don't expose the values, we can do whatever we like with > future numbers (e.g. the "is this a value or a bit field?" question). Alexey Dobriyan suggested to put these parameters into the UAPI and it makes sense because these are user parameters. -- Rgrds, legion
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.