[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191115074003.GB19101@kadam.lan>
Date: Fri, 15 Nov 2019 10:40:03 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Kees Cook <keescook@...omium.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
devel@...verdev.osuosl.org,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org,
Romain Perier <romain.perier@...il.com>,
Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] staging: rtl*: Remove tasklet callback casts
On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote:
> In order to make the entire kernel usable under Clang's Control Flow
> Integrity protections, function prototype casts need to be avoided
> because this will trip CFI checks at runtime (i.e. a mismatch between
> the caller's expected function prototype and the destination function's
> prototype). Many of these cases can be found with -Wcast-function-type,
> which found that the rtl wifi drivers had a bunch of needless function
> casts. Remove function casts for tasklet callbacks in the various drivers.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>
Clang should treat void pointers as a special case. If void pointers
are bad, surely replacing them with unsigned long is even more ambigous
and worse.
regards,
dan carpenter
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
