Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 7 Nov 2019 11:51:38 +0100
From: Ard Biesheuvel <>
To: Miguel Ojeda <>
Cc: Sami Tolvanen <>, Will Deacon <>, 
	Catalin Marinas <>, Steven Rostedt <>, 
	Masami Hiramatsu <>, Dave Martin <>, 
	Kees Cook <>, Laura Abbott <>, 
	Mark Rutland <>, Marc Zyngier <>, 
	Nick Desaulniers <>, Jann Horn <>, 
	Masahiro Yamada <>, 
	clang-built-linux <>, 
	Kernel Hardening <>, 
	Linux ARM <>, 
	linux-kernel <>
Subject: Re: [PATCH v5 11/14] arm64: efi: restore x18 if it was corrupted

On Wed, 6 Nov 2019 at 05:46, Miguel Ojeda
<> wrote:
> On Wed, Nov 6, 2019 at 12:56 AM Sami Tolvanen <> wrote:
> >
> > If we detect a corrupted x18 and SCS is enabled, restore the register
> > before jumping back to instrumented code. This is safe, because the
> > wrapper is called with preemption disabled and a separate shadow stack
> > is used for interrupt handling.
> In case you do v6: I think putting the explanation about why this is
> safe in the existing comment would be best given it is justifying a
> subtlety of the code rather than the change itself. Ard?

Agreed, but only if you have to respin for other reasons.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.