[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANiq72n4o16TB53s6nLLrLCw6v0Brn8GAhKvdzzN7v1tNontCQ@mail.gmail.com>
Date: Mon, 28 Oct 2019 16:31:05 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Sami Tolvanen <samitolvanen@...gle.com>
Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>, Catalin Marinas <catalin.marinas@....com>,
Dave Martin <Dave.Martin@....com>, Jann Horn <jannh@...gle.com>, Joe Perches <joe@...ches.com>,
Kees Cook <keescook@...omium.org>,
Kernel Hardening <kernel-hardening@...ts.openwall.com>, LKML <linux-kernel@...r.kernel.org>,
Laura Abbott <labbott@...hat.com>, Mark Rutland <mark.rutland@....com>,
Masahiro Yamada <yamada.masahiro@...ionext.com>, Masami Hiramatsu <mhiramat@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>, Steven Rostedt <rostedt@...dmis.org>,
Will Deacon <will@...nel.org>, clang-built-linux <clang-built-linux@...glegroups.com>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 05/17] add support for Clang's Shadow Call Stack (SCS)
Hi Sami,
On Mon, 28 Oct 2019 at 16:20 Sami Tolvanen <samitolvanen@...gle.com> wrote:
> Hi Joe,
>
> On Sat, Oct 26, 2019 at 8:57 AM Joe Perches <joe@...ches.com> wrote:
> > > +#if __has_feature(shadow_call_stack)
> > > +# define __noscs __attribute__((no_sanitize("shadow-call-stack")))
> >
> > __no_sanitize__
>
> Sorry, I missed your earlier message about this. I'm following Clang's
> documentation for the attribute:
>
>
> https://clang.llvm.org/docs/ShadowCallStack.html#attribute-no-sanitize-shadow-call-stack
>
> Although __no_sanitize__ seems to work too. Is there a particular
> reason to prefer that form over the one in the documentation?
We decided to do it like that when I introduced compiler_attributes.h.
Given it is hidden behind a definition, we don't care about which one we
use internally; therefore the idea was to avoid clashes as much as possible
with other names/definitions/etc.
The syntax is supported in the compilers we care about (for docs on
attributes, the best reference is GCC's by the way).
Cheers,
Miguel
--
Cheers,
Miguel
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
