[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190925145011.c80c89b56fcee3060cf87773@linux-foundation.org>
Date: Wed, 25 Sep 2019 14:50:11 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Joe Perches <joe@...ches.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>, Stephen
Kitt <steve@....org>, Kees Cook <keescook@...omium.org>, Nitin Gote
<nitin.r.gote@...el.com>, jannh@...gle.com,
kernel-hardening@...ts.openwall.com, Rasmus Villemoes
<rasmus.villemoes@...vas.dk>
Subject: Re: [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms
On Tue, 23 Jul 2019 06:51:36 -0700 Joe Perches <joe@...ches.com> wrote:
> Several uses of strlcpy and strscpy have had defects because the
> last argument of each function is misused or typoed.
>
> Add macro mechanisms to avoid this defect.
>
> stracpy (copy a string to a string array) must have a string
> array as the first argument (dest) and uses sizeof(dest) as the
> count of bytes to copy.
>
> These mechanisms verify that the dest argument is an array of
> char or other compatible types like u8 or s8 or equivalent.
>
> A BUILD_BUG is emitted when the type of dest is not compatible.
>
I'm still reluctant to merge this because we don't have code in -next
which *uses* it. You did have a patch for that against v1, I believe?
Please dust it off and send it along?
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
