[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <457508f39b96caab15ed4bf7ff0d586ffdc850f8.camel@buserror.net>
Date: Wed, 28 Aug 2019 11:44:48 -0500
From: Scott Wood <oss@...error.net>
To: Jason Yan <yanaijie@...wei.com>
Cc: wangkefeng.wang@...wei.com, keescook@...omium.org,
kernel-hardening@...ts.openwall.com, thunder.leizhen@...wei.com,
linux-kernel@...r.kernel.org, npiggin@...il.com, jingxiangfeng@...wei.com,
diana.craciun@....com, paulus@...ba.org, zhaohongjiang@...wei.com,
fanchengyang@...wei.com, linuxppc-dev@...ts.ozlabs.org, yebin10@...wei.com
Subject: Re: [PATCH v6 06/12] powerpc/fsl_booke/32: implement KASLR
infrastructure
On Wed, 2019-08-28 at 19:03 +0800, Jason Yan wrote:
>
> On 2019/8/28 12:54, Scott Wood wrote:
> > On Fri, Aug 09, 2019 at 06:07:54PM +0800, Jason Yan wrote:
> > > +/*
> > > + * To see if we need to relocate the kernel to a random offset
> > > + * void *dt_ptr - address of the device tree
> > > + * phys_addr_t size - size of the first memory block
> > > + */
> > > +notrace void __init kaslr_early_init(void *dt_ptr, phys_addr_t size)
> > > +{
> > > + unsigned long tlb_virt;
> > > + phys_addr_t tlb_phys;
> > > + unsigned long offset;
> > > + unsigned long kernel_sz;
> > > +
> > > + kernel_sz = (unsigned long)_end - KERNELBASE;
> >
> > Why KERNELBASE and not kernstart_addr?
> >
>
> Did you mean kernstart_virt_addr? It should be kernstart_virt_addr.
Yes, kernstart_virt_addr. KERNELBASE will be incorrect if the kernel was
loaded at a nonzero physical address without CONFIG_PHYSICAL_START being
adjusted to match.
-Scott
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
