[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190723065059.30101-1-omosnace@redhat.com>
Date: Tue, 23 Jul 2019 08:50:59 +0200
From: Ondrej Mosnacek <omosnace@...hat.com>
To: selinux@...r.kernel.org,
Paul Moore <paul@...l-moore.com>
Cc: NitinGote <nitin.r.gote@...el.com>,
kernel-hardening@...ts.openwall.com,
Kees Cook <keescook@...omium.org>,
William Roberts <bill.c.roberts@...il.com>
Subject: [PATCH v2] selinux: check sidtab limit before adding a new entry
We need to error out when trying to add an entry above SIDTAB_MAX in
sidtab_reverse_lookup() to avoid overflow on the odd chance that this
happens.
Fixes: ee1a84fdfeed ("selinux: overhaul sidtab to fix bug and improve performance")
Signed-off-by: Ondrej Mosnacek <omosnace@...hat.com>
---
security/selinux/ss/sidtab.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/security/selinux/ss/sidtab.c b/security/selinux/ss/sidtab.c
index e63a90ff2728..1f0a6eaa2d6a 100644
--- a/security/selinux/ss/sidtab.c
+++ b/security/selinux/ss/sidtab.c
@@ -286,6 +286,11 @@ static int sidtab_reverse_lookup(struct sidtab *s, struct context *context,
++count;
}
+ /* bail out if we already reached max entries */
+ rc = -EOVERFLOW;
+ if (count >= SIDTAB_MAX)
+ goto out_unlock;
+
/* insert context into new entry */
rc = -ENOMEM;
dst = sidtab_do_lookup(s, count, 1);
--
2.21.0
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
