[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190611134831.a60c11f4b691d14d04a87e29@linux-foundation.org>
Date: Tue, 11 Jun 2019 13:48:31 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Shyam Saini <shyam.saini@...rulasolutions.com>
Cc: kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org,
keescook@...omium.org, linux-arm-kernel@...ts.infradead.org,
linux-mips@...r.kernel.org, intel-gvt-dev@...ts.freedesktop.org,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
netdev@...r.kernel.org, linux-ext4@...r.kernel.org,
devel@...ts.orangefs.org, linux-mm@...ck.org, linux-sctp@...r.kernel.org,
bpf@...r.kernel.org, kvm@...r.kernel.org, mayhs11saini@...il.com, Alexey
Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF
macro
On Wed, 12 Jun 2019 01:08:36 +0530 Shyam Saini <shyam.saini@...rulasolutions.com> wrote:
> Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD
> and FIELD_SIZEOF which are used to calculate the size of a member of
> structure, so to bring uniformity in entire kernel source tree lets use
> FIELD_SIZEOF and replace all occurrences of other two macros with this.
>
> For this purpose, redefine FIELD_SIZEOF in include/linux/stddef.h and
> tools/testing/selftests/bpf/bpf_util.h and remove its defination from
> include/linux/kernel.h
>
> In favour of FIELD_SIZEOF, this patch also deprecates other two similar
> macros sizeof_field and SIZEOF_FIELD.
>
> For code compatibility reason, retain sizeof_field macro as a wrapper macro
> to FIELD_SIZEOF
As Alexey has pointed out, C structs and unions don't have fields -
they have members. So this is an opportunity to switch everything to
a new member_sizeof().
What do people think of that and how does this impact the patch footprint?
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
