[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAKv+Gu98jQA7XARghVNXq8qEBm4DG77q3K0j-zw-WX_w-4_Q-Q@mail.gmail.com>
Date: Thu, 16 May 2019 10:47:08 +0200
From: Ard Biesheuvel <ard.biesheuvel@...aro.org>
To: Doug Anderson <dianders@...omium.org>
Cc: Chris Packham <chris.packham@...iedtelesis.co.nz>, Kees Cook <keescook@...omium.org>,
Emese Revfy <re.emese@...il.com>, Kernel Hardening <kernel-hardening@...ts.openwall.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gcc-plugins: arm_ssp_per_task_plugin: Fix for older GCC < 6
On Sat, 11 May 2019 at 00:42, Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> > Use gen_rtx_set instead of gen_rtx_SET. The former is a wrapper macro
> > that handles the difference between GCC versions implementing
> > the latter.
> >
> > This fixes the following error on my system with g++ 5.4.0 as the host
> > compiler
> >
> > HOSTCXX -fPIC scripts/gcc-plugins/arm_ssp_per_task_plugin.o
> > scripts/gcc-plugins/arm_ssp_per_task_plugin.c:42:14: error: macro "gen_rtx_SET" requires 3 arguments, but only 2 given
> > mask)),
> > ^
> > scripts/gcc-plugins/arm_ssp_per_task_plugin.c: In function ‘unsigned int arm_pertask_ssp_rtl_execute()’:
> > scripts/gcc-plugins/arm_ssp_per_task_plugin.c:39:20: error: ‘gen_rtx_SET’ was not declared in this scope
> > emit_insn_before(gen_rtx_SET
> >
> > Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> > ---
> > scripts/gcc-plugins/arm_ssp_per_task_plugin.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I can confirm that I was getting compile errors before this patch and
> applying it allowed me to compile and boot. Thanks! :-)
>
> Tested-by: Douglas Anderson <dianders@...omium.org>
>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
