|
Message-ID: <20190509013905.d3oflhz44lnqukzz@gondor.apana.org.au> Date: Thu, 9 May 2019 09:39:06 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Kees Cook <keescook@...omium.org> Cc: Eric Biggers <ebiggers@...nel.org>, Joao Moreira <jmoreira@...e.de>, Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>, X86 ML <x86@...nel.org>, linux-crypto <linux-crypto@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Kernel Hardening <kernel-hardening@...ts.openwall.com> Subject: Re: [PATCH v3 0/7] crypto: x86: Fix indirect function call casts On Wed, May 08, 2019 at 02:08:25PM -0700, Kees Cook wrote: > > For example, quoting the existing code: > > asmlinkage void twofish_dec_blk(struct twofish_ctx *ctx, u8 *dst, > const u8 *src); So just make it asmlinkage void twofish_dec_blk(void *ctx, u8 *dst, const u8 *src); and you won't need any of these casts. Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.