[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4db72046-7510-34cc-5ec4-254f7847cd80@redhat.com>
Date: Fri, 25 Jan 2019 18:38:59 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: Greg KH <gregkh@...uxfoundation.org>,
Alexander Popov <alex.popov@...ux.com>
Cc: Radim Krcmar <rkrcmar@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
Nadav Amit <nadav.amit@...il.com>, Andy Lutomirski <luto@...nel.org>,
Stefan Hajnoczi <stefanha@...hat.com>, H Peter Anvin <hpa@...or.com>,
x86@...nel.org, kvm@...r.kernel.org, kernel-hardening@...ts.openwall.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] KVM: x86: Fix single-step debugging
On 21/01/19 15:24, Greg KH wrote:
> On Mon, Jan 21, 2019 at 03:48:40PM +0300, Alexander Popov wrote:
>> The single-step debugging of KVM guests on x86 is broken: if we run
>> gdb 'stepi' command at the breakpoint when the guest interrupts are
>> enabled, RIP always jumps to native_apic_mem_write(). Then other
>> nasty effects follow.
>>
>> Long investigation showed that on Jun 7, 2017 the
>> commit c8401dda2f0a00cd25c0 ("KVM: x86: fix singlestepping over syscall")
>> introduced the kvm_run.debug corruption: kvm_vcpu_do_singlestep() can
>> be called without X86_EFLAGS_TF set.
>>
>> Let's fix it. Please consider that for -stable.
>>
>> Signed-off-by: Alexander Popov <alex.popov@...ux.com>
>> ---
>> arch/x86/kvm/x86.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>
>
Yup, will take care of doing this properly. :)
Paolo
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
