Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 23 Jan 2019 06:21:44 -0700
From: William Kucharski <>
To: Jann Horn <>
Cc: Greg KH <>, Kees Cook <>,
        kernel list <>,
        Ard Biesheuvel <>,
        Laura Abbott <>,
        Alexander Popov <>,
        xen-devel <>,,,
        intel-wired-lan <>,
        Network Development <>,,,
        Linux-MM <>,,,
        linux-security-module <>,
        Kernel Hardening <>
Subject: Re: [PATCH 1/3] treewide: Lift switch variables out of switches

> On Jan 23, 2019, at 5:09 AM, Jann Horn <> wrote:
> AFAICS this only applies to switch statements (because they jump to a
> case and don't execute stuff at the start of the block), not blocks
> after if/while/... .

It bothers me that we are going out of our way to deprecate valid C constructs
in favor of placing the declarations elsewhere.

As current compiler warnings would catch any reference before initialization
usage anyway, it seems like we are letting a compiler warning rather than the
language standard dictate syntax.

Certainly if we want to make it a best practice coding style issue we can, and
then an appropriate note explaining why should be added to

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.