[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <624caa9a-e591-a1f4-40d1-49db10a91f03@gmail.com>
Date: Mon, 29 Oct 2018 20:07:23 +0200
From: Igor Stoppa <igor.stoppa@...il.com>
To: Dave Hansen <dave.hansen@...el.com>, Mimi Zohar
<zohar@...ux.vnet.ibm.com>, Kees Cook <keescook@...omium.org>,
Matthew Wilcox <willy@...radead.org>, Dave Chinner <david@...morbit.com>,
James Morris <jmorris@...ei.org>, Michal Hocko <mhocko@...nel.org>,
kernel-hardening@...ts.openwall.com, linux-integrity@...r.kernel.org,
linux-security-module@...r.kernel.org
Cc: igor.stoppa@...wei.com, Dave Hansen <dave.hansen@...ux.intel.com>,
Jonathan Corbet <corbet@....net>, Laura Abbott <labbott@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Chintan Pandya <cpandya@...eaurora.org>, Joe Perches <joe@...ches.com>,
"Luis R. Rodriguez" <mcgrof@...nel.org>, Thomas Gleixner
<tglx@...utronix.de>, Kate Stewart <kstewart@...uxfoundation.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Philippe Ombredanne <pombredanne@...b.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/17] prmem: vmalloc support for dynamic allocation
On 25/10/2018 01:26, Dave Hansen wrote:
> On 10/23/18 2:34 PM, Igor Stoppa wrote:
>> +#define VM_PMALLOC 0x00000100 /* pmalloc area - see docs */
>> +#define VM_PMALLOC_WR 0x00000200 /* pmalloc write rare area */
>> +#define VM_PMALLOC_PROTECTED 0x00000400 /* pmalloc protected area */
>
> Please introduce things as you use them. It's impossible to review a
> patch that just says "see docs" that doesn't contain any docs. :)
Yes, otoh it's a big pain in the neck to keep the docs split into
smaller patches interleaved with the code, at least while the code is
still in a flux.
And since the docs refer to the sources, for the automated documentation
of the API, I cannot just put the documentation at the beginning of the
patchset.
Can I keep the docs as they are, for now, till the code is more stable?
--
igor
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
