[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20181019042109.8064-2-mpe@ellerman.id.au>
Date: Fri, 19 Oct 2018 15:21:09 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: rostedt@...dmis.org
Cc: linux-kernel@...r.kernel.org,
kernel-hardening@...ts.openwall.com,
jannh@...gle.com,
keescook@...omium.org
Subject: [PATCH v2 2/2] seq_buf: Use size_t for len in seq_buf_puts()
Jann Horn points out that we're using unsigned int for len in
seq_buf_puts(), which could potentially overflow if we're passed a
UINT_MAX sized string.
The rest of the code already uses size_t, so we should also use that
in seq_buf_puts() to avoid any issues.
Suggested-by: Jann Horn <jannh@...gle.com>
Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
---
lib/seq_buf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
v2: New in v2.
diff --git a/lib/seq_buf.c b/lib/seq_buf.c
index 6aabb609dd87..bd807f545a9d 100644
--- a/lib/seq_buf.c
+++ b/lib/seq_buf.c
@@ -140,7 +140,7 @@ int seq_buf_bprintf(struct seq_buf *s, const char *fmt, const u32 *binary)
*/
int seq_buf_puts(struct seq_buf *s, const char *str)
{
- unsigned int len = strlen(str);
+ size_t len = strlen(str);
WARN_ON(s->size == 0);
--
2.17.2
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
