Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180903152616.GE27886@tassilo.jf.intel.com>
Date: Mon, 3 Sep 2018 08:26:16 -0700
From: Andi Kleen <ak@...ux.intel.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: jsteckli@...zon.de, David Woodhouse <dwmw@...zon.co.uk>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	juerg.haefliger@....com, deepa.srinivasan@...cle.com,
	Jim Mattson <jmattson@...gle.com>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	linux-mm <linux-mm@...ck.org>, Thomas Gleixner <tglx@...utronix.de>,
	joao.m.martins@...cle.com, pradeep.vincent@...cle.com,
	Khalid Aziz <khalid.aziz@...cle.com>, kanth.ghatraju@...cle.com,
	Liran Alon <liran.alon@...cle.com>, Kees Cook <keescook@...gle.com>,
	Kernel Hardening <kernel-hardening@...ts.openwall.com>,
	chris.hyser@...cle.com, Tyler Hicks <tyhicks@...onical.com>,
	John Haxby <john.haxby@...cle.com>, Jon Masters <jcm@...hat.com>
Subject: Re: Redoing eXclusive Page Frame Ownership (XPFO) with isolated CPUs
 in mind (for KVM to isolate its guests per CPU)

On Sat, Sep 01, 2018 at 02:38:43PM -0700, Linus Torvalds wrote:
> On Fri, Aug 31, 2018 at 12:45 AM Julian Stecklina <jsteckli@...zon.de> wrote:
> >
> > I've been spending some cycles on the XPFO patch set this week. For the
> > patch set as it was posted for v4.13, the performance overhead of
> > compiling a Linux kernel is ~40% on x86_64[1]. The overhead comes almost
> > completely from TLB flushing. If we can live with stale TLB entries
> > allowing temporary access (which I think is reasonable), we can remove
> > all TLB flushing (on x86). This reduces the overhead to 2-3% for
> > kernel compile.
> 
> I have to say, even 2-3% for a kernel compile sounds absolutely horrendous.
> 
> Kernel bullds are 90% user space at least for me, so a 2-3% slowdown
> from a kernel is not some small unnoticeable thing.

Also the problem is that depending on the workload everything may fit
into the TLBs, so the temporary stale TLB entries may be around
for a long time. Modern CPUs have very large TLBs, and good
LRU policies. For the kernel entries with global bit set and
which are used for something there may be no reason ever to evict.

Julian, I think you would need at least some quantitative perfmon data about
TLB replacement rates in the kernel to show that it's "reasonable"
instead of hand waving.

Most likely I suspect you would need a low frequency regular TLB
flush for the global entries at least, which will increase
the overhead again.

-Andi

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.