Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 27 Aug 2018 12:08:49 -0700
From: Andy Lutomirski <>
To: Jann Horn <>
Cc: Kees Cook <>, Thomas Gleixner <>, 
	Ingo Molnar <>, X86 ML <>, Andy Lutomirski <>, 
	Kernel Hardening <>, Tony Luck <>, 
	Borislav Petkov <>, LKML <>, 
	Dmitry Vyukov <>, linux-edac <>
Subject: Re: [PATCH v2 5/7] x86: plumb error code and fault address through to
 fault handlers

On Mon, Aug 27, 2018 at 11:56 AM, Jann Horn <> wrote:
> This is preparation for looking at trap number and fault address in the
> handlers for uaccess errors.
> This patch should not change any behavior.

Confused.  $SUBJECT says you're plumbing the error code through, and
you are sort of doing it:

> -int fixup_exception(struct pt_regs *regs, int trapnr)
> +int fixup_exception(struct pt_regs *regs, int trapnr, unsigned long error_code,
> +                   unsigned long fault_addr)
>  {

It's available here...

>         const struct exception_table_entry *e;
>         ex_handler_t handler;
> @@ -202,7 +212,7 @@ int fixup_exception(struct pt_regs *regs, int trapnr)
>                 return 0;
>         handler = ex_fixup_handler(e);
> -       return handler(e, regs, trapnr);
> +       return handler(e, regs, trapnr, fault_addr);

... but you don't pass it into the handlers.  Is this intentional?

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.