Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c2c67217-e120-468b-b59a-05813a64c448@infradead.org>
Date: Mon, 25 Jun 2018 16:51:30 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Thomas Garnier <thgarnie@...gle.com>, kernel-hardening@...ts.openwall.com
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
 Josh Poimboeuf <jpoimboe@...hat.com>,
 Philippe Ombredanne <pombredanne@...b.com>,
 Kate Stewart <kstewart@...uxfoundation.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Francis Deslauriers <francis.deslauriers@...icios.com>,
 "H.J. Lu" <hjl.tools@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 23/27] x86/modules: Adapt module loading for PIE
 support

On 06/25/18 15:39, Thomas Garnier wrote:
> Adapt module loading to support PIE relocations. Generate dynamic GOT if
> a symbol requires it but no entry exists in the kernel GOT.

Hi,

This patch description (and a few others with the same sentence) is a little
confusing to me:

> Position Independent Executable (PIE) support will allow to extend the
> KASLR randomization range 0xffffffff80000000.

Is there a word missing after "range"?  May "below"?
As is, it seems to imply "range by 0xffffffff80000000."


thanks.

> 
> Signed-off-by: Thomas Garnier <thgarnie@...gle.com>
> ---
>  arch/x86/Makefile               |   4 +
>  arch/x86/include/asm/module.h   |  11 ++
>  arch/x86/include/asm/sections.h |   4 +
>  arch/x86/kernel/module.c        | 181 +++++++++++++++++++++++++++++++-
>  arch/x86/kernel/module.lds      |   3 +
>  5 files changed, 198 insertions(+), 5 deletions(-)
>  create mode 100644 arch/x86/kernel/module.lds


-- 
~Randy

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.