|
Message-ID: <f733e4630e424e0aaf402d5d840cb6e2@AcuMS.aculab.com> Date: Tue, 8 May 2018 09:39:58 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Salvatore Mesoraca' <s.mesoraca16@...il.com>, Florian Fainelli <f.fainelli@...il.com> CC: Andrew Lunn <andrew@...n.ch>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Kees Cook <keescook@...omium.org>, Vivien Didelot <vivien.didelot@...oirfairelinux.com> Subject: RE: [PATCH v2] net: dsa: drop some VLAs in switch.c From: Salvatore Mesoraca > Sent: 07 May 2018 20:03 ... > This optimization will save us an allocation when number of ports is > less than 32 or 64 (depending on arch). > IMHO it's useful, if you consider that, right now, DSA works only with > 12-ports switches. Why not just error out if the number of ports is greater than the compile-time limit? Worry about dynamic allocation if you need a lot more than 64 ports. David
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.