|
Message-ID: <01ec5680-b1de-5473-f32b-89729d9fcc70@infradead.org> Date: Sat, 28 Apr 2018 20:36:20 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: Igor Stoppa <igor.stoppa@...il.com>, mhocko@...nel.org, akpm@...ux-foundation.org, keescook@...omium.org, linux-mm@...ck.org, kernel-hardening@...ts.openwall.com, linux-security-module@...r.kernel.org Cc: willy@...radead.org, labbott@...hat.com, linux-kernel@...r.kernel.org, igor.stoppa@...wei.com Subject: Re: [PATCH 3/3] genalloc: selftest On 04/28/2018 07:45 PM, Igor Stoppa wrote: > Introduce a set of macros for writing concise test cases for genalloc. > > The test cases are meant to provide regression testing, when working on > new functionality for genalloc. > > Primarily they are meant to confirm that the various allocation strategy > will continue to work as expected. > > The execution of the self testing is controlled through a Kconfig option. > > The testing takes place in the very early stages of main.c, to ensure > that failures in genalloc are caught before they can cause unexplained > erratic behavior in any of genalloc users. > > Therefore, it would not be advisable to implement it as module. > > Signed-off-by: Igor Stoppa <igor.stoppa@...wei.com> Hi, > --- > init/main.c | 2 + > lib/Kconfig | 15 ++ > lib/Makefile | 1 + > lib/test_genalloc.c | 410 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 428 insertions(+) > create mode 100644 lib/test_genalloc.c > > diff --git a/init/main.c b/init/main.c > index b795aa341a3a..b3b319d91b0e 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -91,6 +91,7 @@ > #include <linux/cache.h> > #include <linux/rodata_test.h> > #include <linux/jump_label.h> > +#include <linux/test_genalloc.h> > > #include <asm/io.h> > #include <asm/bugs.h> > @@ -679,6 +680,7 @@ asmlinkage __visible void __init start_kernel(void) > */ > mem_encrypt_init(); > > + test_genalloc(); Is there a stub for test_genalloc() when its config option is not enabled? I don't see it. > #ifdef CONFIG_BLK_DEV_INITRD > if (initrd_start && !initrd_below_start_ok && > page_to_pfn(virt_to_page((void *)initrd_start)) < min_low_pfn) { > diff --git a/lib/Kconfig b/lib/Kconfig > index 09565d779324..2bf89af50728 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -303,6 +303,21 @@ config DECOMPRESS_LZ4 > config GENERIC_ALLOCATOR > bool > These TEST_ kconfig symbols should be in lib/Kconfig.debug, not lib/Kconfig. > +config TEST_GENERIC_ALLOCATOR > + bool "genalloc tester" > + default n > + select GENERIC_ALLOCATOR This should depend on GENERIC_ALLOCATOR, not select it. See TEST_PARMAN, TEST_BPF, TEST_FIRMWARE, TEST_SYSCTL, TEST_DEBUG_VIRTUAL in lib/Kconfig.debug. > + help > + Enable automated testing of the generic allocator. > + The testing is primarily for the tracking of allocated space. > + > +config TEST_GENERIC_ALLOCATOR_VERBOSE > + bool "make the genalloc tester more verbose" > + default n > + select TEST_GENERIC_ALLOCATOR depends on TEST_GENERIC_ALLOCATOR > + help > + More information will be displayed during the self-testing. > + > # > # reed solomon support is select'ed if needed > # > diff --git a/lib/test_genalloc.c b/lib/test_genalloc.c > new file mode 100644 > index 000000000000..ab9984861517 > --- /dev/null > +++ b/lib/test_genalloc.c > @@ -0,0 +1,410 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * test_genalloc.c > + * > + * (C) Copyright 2017 Huawei Technologies Co. Ltd. > + * Author: Igor Stoppa <igor.stoppa@...wei.com> > + */ > + > +#include <linux/module.h> > +#include <linux/printk.h> > +#include <linux/init.h> > +#include <linux/vmalloc.h> > +#include <linux/string.h> > +#include <linux/debugfs.h> > +#include <linux/atomic.h> > +#include <linux/genalloc.h> > + > +#include <linux/test_genalloc.h> > + > + > +/* > + * In case of failure of any of these tests, memory corruption is almost > + * guarranteed; allowing the boot to continue means risking to corrupt guaranteed; > + * also any filesystem/block device accessed write mode. > + * Therefore, BUG_ON() is used, when testing. > + */ -- ~Randy
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.