[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180418134729.fzu4r7rvgdzlckw7@lakrids.cambridge.arm.com>
Date: Wed, 18 Apr 2018 14:47:30 +0100
From: Mark Rutland <mark.rutland@....com>
To: Andrew Jones <drjones@...hat.com>
Cc: linux-arm-kernel@...ts.infradead.org, arnd@...db.de,
catalin.marinas@....com, cdall@...nel.org,
kvmarm@...ts.cs.columbia.edu, linux-arch@...r.kernel.org,
marc.zyngier@....com, ramana.radhakrishnan@....com,
suzuki.poulose@....com, will.deacon@....com,
linux-kernel@...r.kernel.org, awallis@...eaurora.org,
kernel-hardening@...ts.openwall.com
Subject: Re: [PATCHv3 03/11] arm64/kvm: hide ptrauth from guests
On Wed, Apr 18, 2018 at 03:19:26PM +0200, Andrew Jones wrote:
> On Tue, Apr 17, 2018 at 07:37:27PM +0100, Mark Rutland wrote:
> > @@ -1000,6 +1000,15 @@ static u64 read_id_reg(struct sys_reg_desc const *r, bool raz)
> > task_pid_nr(current));
> >
> > val &= ~(0xfUL << ID_AA64PFR0_SVE_SHIFT);
> > + } else if (id == SYS_ID_AA64ISAR1_EL1) {
> > + const u64 ptrauth_mask = (0xfUL << ID_AA64ISAR1_APA_SHIFT) |
> > + (0xfUL << ID_AA64ISAR1_API_SHIFT) |
> > + (0xfUL << ID_AA64ISAR1_GPA_SHIFT) |
> > + (0xfUL << ID_AA64ISAR1_GPI_SHIFT);
> > + if (val & ptrauth_mask)
> > + pr_err_once("kvm [%i]: ptrauth unsupported for guests, suppressing\n",
> > + task_pid_nr(current));
>
> Marc just changed the equivalent SVE pr_err_once() to kvm_debug().
> So we probably want to do the same here.
Good point. Done.
> > + val &= ~ptrauth_mask;
> > } else if (id == SYS_ID_AA64MMFR1_EL1) {
> > if (val & (0xfUL << ID_AA64MMFR1_LOR_SHIFT))
> > pr_err_once("kvm [%i]: LORegions unsupported for guests, suppressing\n",
> > --
> > 2.11.0
> >
>
> Otherwise
>
> Reviewed-by: Andrew Jones <drjones@...hat.com>
Cheers!
Mark.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
