[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180416061044.z6eb4psw2sbszemb@gmail.com>
Date: Mon, 16 Apr 2018 08:10:44 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Joao Moreira <jmoreira@...e.de>
Cc: kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org,
x86@...nel.org, herbert@...dor.apana.org.au, davem@...emloft.net,
tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
gregkh@...uxfoundation.org, keescook@...omium.org
Subject: Re: [PATCH 1/4] x86/crypto: camellia: Fix function prototypes
* Joao Moreira <jmoreira@...e.de> wrote:
> Convert the use of 'struct camellia_ctx *' to 'void *' in prototypes of
> functions which are referenced through 'struct common_glue_func_entry',
> making their prototypes match those of this struct and, consequently,
> turning them compatible with CFI requirements.
>
> Whenever needed, cast 'void *' to 'struct camellia_ctx *'.
> +static inline void camellia_enc_blk(void *ctx, u8 *dst, const u8 *src)
> {
> - __camellia_enc_blk(ctx, dst, src, false);
> + __camellia_enc_blk((struct camellia_ctx *) ctx, dst, src, false);
> }
I don't see how this is an improvement: instead of having a proper type there's
now an opaque type and an ugly (and dangerous) type cast.
What does "compatible with CFI requirements" mean?
Thanks,
Ingo
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
