[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180408031619.GB25197@gondor.apana.org.au>
Date: Sun, 8 Apr 2018 11:16:20 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Salvatore Mesoraca <s.mesoraca16@...il.com>
Cc: linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
linux-crypto@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Kees Cook <keescook@...omium.org>,
Eric Biggers <ebiggers3@...il.com>,
Laura Abbott <labbott@...hat.com>
Subject: Re: [PATCH 3/6] crypto: api - avoid VLA use
On Sat, Apr 07, 2018 at 08:38:20PM +0200, Salvatore Mesoraca wrote:
>
> int crypto_init_cipher_ops(struct crypto_tfm *tfm)
> {
> + const unsigned long alignmask = crypto_tfm_alg_alignmask(tfm);
> + const unsigned int size = crypto_tfm_alg_blocksize(tfm);
> struct cipher_tfm *ops = &tfm->crt_cipher;
> struct cipher_alg *cipher = &tfm->__crt_alg->cra_cipher;
>
> + if (size > MAX_BLOCKSIZE || alignmask > MAX_ALIGNMASK)
> + return -EINVAL;
> +
This check should be done when the algorithm is registered. Perhaps
crypto_check_alg.
Thanks,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
