[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXu5j+cETZ7udEG9pgmxfdwZLmNzO0Br4KAL7_ZdyOP2_CANQ@mail.gmail.com>
Date: Sat, 7 Apr 2018 12:56:34 -0700
From: Kees Cook <keescook@...omium.org>
To: Salvatore Mesoraca <s.mesoraca16@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
Kernel Hardening <kernel-hardening@...ts.openwall.com>,
linux-crypto <linux-crypto@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
Herbert Xu <herbert@...dor.apana.org.au>, Eric Biggers <ebiggers3@...il.com>,
Laura Abbott <labbott@...hat.com>
Subject: Re: [PATCH 0/6] Remove several VLAs in the crypto subsystem
On Sat, Apr 7, 2018 at 11:38 AM, Salvatore Mesoraca
<s.mesoraca16@...il.com> wrote:
> As suggested by Laura Abbott[2], I'm resending my patch with
> MAX_BLOCKSIZE and MAX_ALIGNMASK defined in an header, so they
> can be used in other places.
> I take this opportuinuty to deal with some other VLAs not
> handled in the old patch.
>
> [1] http://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
> [2] http://lkml.kernel.org/r/4e536889-439a-49e6-dd95-2d4286913202@redhat.com
>
> Salvatore Mesoraca (6):
> crypto: api - laying macros for statically allocated buffers
> crypto: ctr - avoid VLA use
> crypto: api - avoid VLA use
> crypto: pcbc - avoid VLA use
> crypto: cts - avoid VLA use
> crypto: cfb - avoid VLA use
>
> crypto/cfb.c | 14 ++++++++++----
> crypto/cipher.c | 7 ++++++-
> crypto/ctr.c | 13 +++++++++++--
> crypto/cts.c | 8 ++++++--
> crypto/internal.h | 8 ++++++++
> crypto/pcbc.c | 9 +++++++--
> 6 files changed, 48 insertions(+), 11 deletions(-)
These all look good to me! Thanks for the refactoring. :)
Reviewed-by: Kees Cook <keescook@...omium.org>
-Kees
--
Kees Cook
Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
