[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXu5jKVKFmVN-esd5N7B-6mirZv5fm01=uOoq_02jL3idgCVw@mail.gmail.com>
Date: Thu, 5 Apr 2018 15:09:42 -0700
From: Kees Cook <keescook@...omium.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Martin Uecker <Martin.Uecker@....uni-goettingen.de>, Josh Poimboeuf <jpoimboe@...hat.com>,
Rasmus Villemoes <linux@...musvillemoes.dk>, Randy Dunlap <rdunlap@...radead.org>,
Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Ingo Molnar <mingo@...nel.org>,
David Laight <David.Laight@...lab.com>, Ian Abbott <abbotti@....co.uk>,
LKML <linux-kernel@...r.kernel.org>,
Kernel Hardening <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH v7] kernel.h: Retain constant expression output for max()/min()
On Thu, Apr 5, 2018 at 2:20 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> On Thu, Apr 5, 2018 at 1:42 PM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>>
>> Ok, applied.
>
> Ugh, during the merge window, we had actually grown a new example of
> that "different enum types" problem:
>
> struct drm_prop_enum_list enum_list[max(DRM_COLOR_ENCODING_MAX,
> DRM_COLOR_RANGE_MAX)];
>
> in drm_plane_create_color_properties() in the drm drm_color_mgmt.c file.
>
> I ended up just fixing it up manually and added it to the commit. You
> should double-check my change, I've pushed it out now that the build
> seems ok for me.
Looks good; thanks!
> There may be others hiding that weren't caught by my limited build
> testing, trhough. So please keep an eye out for build warnings.
I'll spin up my full multi-arch allmodconfig builds and see if
anything kicks out...
-Kees
--
Kees Cook
Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
