[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87fu52n96k.fsf@intel.com>
Date: Wed, 14 Mar 2018 14:17:07 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Salvatore Mesoraca <s.mesoraca16@...il.com>, linux-kernel@...r.kernel.org
Cc: dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org, kernel-hardening@...ts.openwall.com, David Airlie <airlied@...ux.ie>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Kees Cook <keescook@...omium.org>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Salvatore Mesoraca <s.mesoraca16@...il.com>
Subject: Re: [PATCH] drm/i915: drop various VLAs in i915_debugfs.c
On Tue, 13 Mar 2018, Salvatore Mesoraca <s.mesoraca16@...il.com> wrote:
> Avoid 3 VLAs[1] by using real constant expressions instead of variables.
> The compiler should be able to optimize the original code and avoid using
> any actual VLAs. Anyway this change is useful because it will avoid a false
> positives with -Wvla, it might also help the compiler generating better
> code.
Thanks for your patch. However, Chris beat you to it with:
7aa0b14ede64 ("drm/i915: Remove variable length arrays from sseu debugfs
printers")
as well as adding -Wvla to our subdir-ccflags-y to prevent more from
cropping up:
c5c2b11894f4 ("drm/i915: Warn against variable length arrays")
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
