[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <874llpe246.fsf@kamboji.qca.qualcomm.com>
Date: Fri, 09 Mar 2018 16:48:41 +0200
From: Kalle Valo <kvalo@...eaurora.org>
To: Himanshu Jha <morganfreeman6991@...il.com>
Cc: Andreas Christoforou <andreaschristofo@...il.com>, keescook@...omium.org, kernel-hardening@...ts.openwall.com, QCA ath9k Development <ath9k-devel@....qualcomm.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage
Himanshu Jha <morganfreeman6991@...il.com> writes:
> On Fri, Mar 09, 2018 at 02:30:12PM +0200, Andreas Christoforou wrote:
>> The kernel would like to have all stack VLA usage removed.
>>
>> Signed-off-by: Andreas Christoforou <andreaschristofo@...il.com>
>> ---
>> drivers/net/wireless/ath/ath9k/dfs.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/dfs.c
>> b/drivers/net/wireless/ath/ath9k/dfs.c
>> index 6fee9a4..cfb0f84 100644
>> --- a/drivers/net/wireless/ath/ath9k/dfs.c
>> +++ b/drivers/net/wireless/ath/ath9k/dfs.c
>> @@ -41,7 +41,6 @@ static const int BIN_DELTA_MAX = 10;
>>
>> /* we need at least 3 deltas / 4 samples for a reliable chirp detection */
>> #define NUM_DIFFS 3
>> -static const int FFT_NUM_SAMPLES = (NUM_DIFFS + 1);
>
> Are you sure it is correct ?
> Look for other users of "FFT_NUM_SAMPLES".
>
>> /* Threshold for difference of delta peaks */
>> static const int MAX_DIFF = 2;
>> @@ -101,7 +100,7 @@ static bool ath9k_check_chirping(struct ath_softc *sc, u8 *data,
>> int datalen, bool is_ctl, bool is_ext)
>> {
>> int i;
>> - int max_bin[FFT_NUM_SAMPLES];
>> + int max_bin[NUM_DIFFS + 1];
>> struct ath_hw *ah = sc->sc_ah;
>> struct ath_common *common = ath9k_hw_common(ah);
>> int prev_delta;
>
> Always compile test the driver before sending a patch.
> Also, patch title seems incorrect *ath9k*
>
> himanshu@...anshu-Vostro-3559:~/linux-next$ git log --oneline
> drivers/net/wireless/ath/ath9k/dfs.c
> 626ab67 ath9k: dfs: use swap macro in ath9k_check_chirping
> 50c8cd4 ath9k: remove cast to void pointer
> 8fc2b61 ath9k: DFS - add pulse chirp detection for FCC
> ....
Yeah, just "ath9k:" is enough as the prefix, no need to have full
directory path in the title.
--
Kalle Valo
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
