[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <98df3380-a142-871e-5a18-b356088e33ea@huawei.com>
Date: Wed, 7 Mar 2018 17:46:53 +0200
From: Igor Stoppa <igor.stoppa@...wei.com>
To: Mike Rapoport <rppt@...ux.vnet.ibm.com>
CC: <david@...morbit.com>, <willy@...radead.org>, <keescook@...omium.org>,
<mhocko@...nel.org>, <labbott@...hat.com>,
<linux-security-module@...r.kernel.org>, <linux-mm@...ck.org>,
<linux-kernel@...r.kernel.org>, <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH 1/7] genalloc: track beginning of allocations
On 07/03/18 16:48, Igor Stoppa wrote:
>
>
> On 06/03/18 15:19, Mike Rapoport wrote:
>> On Wed, Feb 28, 2018 at 10:06:14PM +0200, Igor Stoppa wrote:
[...]
>>> + * get_boundary() - verifies address, then measure length.
>>
>> There's some lack of consistency between the name and implementation and
>> the description.
>> It seems that it would be simpler to actually make it get_length() and
>> return the length of the allocation or nentries if the latter is smaller.
>> Then in gen_pool_free() there will be no need to recalculate nentries
>> again.
>
> There is an error in the documentation. I'll explain below.
Argh, I do not know why I came out with that.
Yes, your comment is correct. I've modified the function accordingly and
it is simpler.
I will post it in the next revision.
--
igor
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
