[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5ec5d25a-dbf2-5be4-b449-3704254f8117@huawei.com>
Date: Mon, 26 Feb 2018 18:37:36 +0200
From: Igor Stoppa <igor.stoppa@...wei.com>
To: Matthew Wilcox <willy@...radead.org>
CC: <david@...morbit.com>, <keescook@...omium.org>, <mhocko@...nel.org>,
<labbott@...hat.com>, <linux-security-module@...r.kernel.org>,
<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
<kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH 3/7] struct page: add field for vm_struct
On 25/02/18 05:38, Matthew Wilcox wrote:
> On Fri, Feb 23, 2018 at 04:48:03PM +0200, Igor Stoppa wrote:
>> @@ -1769,6 +1771,9 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
>>
>> kmemleak_vmalloc(area, size, gfp_mask);
>>
>> + for (i = 0; i < area->nr_pages; i++)
>> + area->pages[i]->area = area;
>> +
>> return addr;
>>
>> fail:
>
> IMO, this is the wrong place to initialise the page->area. It should be
> done in __vmalloc_area_node() like so:
>
> area->nr_pages = i;
> goto fail;
> }
> + page->area = area;
> area->pages[i] = page;
> if (gfpflags_allow_blocking(gfp_mask))
> cond_resched();
>
ok
--
igor
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
