[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXu5jJaQUbwo0_a3KpzzV0Roc898bkO7xQ5VScbgTe-s59TQg@mail.gmail.com>
Date: Wed, 21 Feb 2018 17:28:17 -0800
From: Kees Cook <keescook@...omium.org>
To: Christopher Lameter <cl@...ux.com>
Cc: Matthew Wilcox <willy@...radead.org>, Andrew Morton <akpm@...ux-foundation.org>,
Matthew Wilcox <mawilcox@...rosoft.com>, Linux-MM <linux-mm@...ck.org>,
LKML <linux-kernel@...r.kernel.org>,
Kernel Hardening <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct
On Thu, Feb 15, 2018 at 9:06 AM, Christopher Lameter <cl@...ux.com> wrote:
> On Thu, 15 Feb 2018, Matthew Wilcox wrote:
>
>> I dunno. Yes, there's macro trickery going on here, but it certainly
>> resembles a function. It doesn't fail any of the rules laid out in that
>> chapter of coding-style about unacceptable uses of macros.
>
> It sure looks like a function but does magic things with the struct
> parameter. So its not working like a function and the capitalization makes
> one aware of that.
I think readability trumps that -- nearly everything else in the
kernel that hides these kinds of details is lower case.
-Kees
--
Kees Cook
Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
