[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e7ea02b4-3d43-9543-3d14-61c27e155042@huawei.com>
Date: Mon, 12 Feb 2018 13:26:28 +0200
From: Igor Stoppa <igor.stoppa@...wei.com>
To: Mike Rapoport <rppt@...ux.vnet.ibm.com>
CC: <willy@...radead.org>, <rdunlap@...radead.org>, <corbet@....net>,
<keescook@...omium.org>, <mhocko@...nel.org>, <labbott@...hat.com>,
<jglisse@...hat.com>, <hch@...radead.org>, <cl@...ux.com>,
<linux-security-module@...r.kernel.org>, <linux-mm@...ck.org>,
<linux-kernel@...r.kernel.org>, <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH 4/6] Protectable Memory
On 11/02/18 14:37, Mike Rapoport wrote:
> On Sun, Feb 11, 2018 at 05:19:18AM +0200, Igor Stoppa wrote:
>> + * Return: 0 if the object does not belong to pmalloc, 1 if it belongs to
>> + * pmalloc, -1 if it partially overlaps pmalloc meory, but incorectly.
>
> typo: ^ memory
thanks :-(
[...]
>> +/**
>> + * When the sysfs is ready to receive registrations, connect all the
>> + * pools previously created. Also enable further pools to be connected
>> + * right away.
>> + */
>
> This does not seem as kernel-doc comment. Please either remove the second *
> from the opening comment mark or reformat the comment.
For this too, I thought I had caught them all, but I was wrong ...
I didn't find any mention of automated checking for comments.
Is there such tool?
--
thanks, igor
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
