[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171204082111.GB21565@eros>
Date: Mon, 4 Dec 2017 19:21:11 +1100
From: "Tobin C. Harding" <me@...in.cc>
To: Kaiwan N Billimoria <kaiwan.billimoria@...il.com>
Cc: Alexander Kapshuk <alexander.kapshuk@...il.com>,
linux-kernel <linux-kernel@...r.kernel.org>,
kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH] leaking_addresses: add support for 32-bit kernel
addresses
On Mon, Dec 04, 2017 at 10:51:53AM +0530, Kaiwan N Billimoria wrote:
> > On Mon, Dec 4, 2017 at 10:25 AM, Tobin C. Harding <me@...in.cc> wrote:
> >>
> >> > With the 'eval', no warning, it's fine.
> >>
> >> Why not use hex()?
> >
> >> >
> >> > foreach my $config_file (@config_files) {
> >> > + $config_file =~ s/\R*//g;
> >>
> >> Is there some reason you don't use chomp()?
> >
>
> Wrt your suggestions:
>
> ---
> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> index 9906dcf8b807..260b52e456f1 100755
> --- a/scripts/leaking_addresses.pl
> +++ b/scripts/leaking_addresses.pl
> @@ -266,7 +266,7 @@ sub is_false_positive
> sub is_false_positive_ix86_32
> {
> my ($match) = @_;
> - state $page_offset = eval get_page_offset(); # only gets called once
> + state $page_offset = hex get_page_offset(); # only gets called once
I don't think this is valid ;) I meant use hex() to convert the string
to an int so it doesn't throw the warning (inside get_page_offset()).
thanks,
Tobin.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
