[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEiveUc37nt2gH7K9-o3iZn1tCLie6r9FOpARxaygm03NNHbjQ@mail.gmail.com>
Date: Mon, 27 Nov 2017 22:35:41 +0100
From: Djalal Harouni <tixxdz@...il.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Kees Cook <keescook@...omium.org>, Andy Lutomirski <luto@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>, "Luis R. Rodriguez" <mcgrof@...nel.org>,
James Morris <james.l.morris@...cle.com>, Ben Hutchings <ben.hutchings@...ethink.co.uk>,
Solar Designer <solar@...nwall.com>, Serge Hallyn <serge@...lyn.com>, Jessica Yu <jeyu@...nel.org>,
Rusty Russell <rusty@...tcorp.com.au>, linux-kernel <linux-kernel@...r.kernel.org>,
LSM List <linux-security-module@...r.kernel.org>, kernel-hardening@...ts.openwall.com,
Jonathan Corbet <corbet@....net>, Ingo Molnar <mingo@...nel.org>,
"David S. Miller" <davem@...emloft.net>, Network Development <netdev@...r.kernel.org>,
Peter Zijlstra <peterz@...radead.org>, Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()
Hi Randy,
On Mon, Nov 27, 2017 at 7:48 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
> Hi,
>
> Mostly typos/spellos...
>
>
> On 11/27/2017 09:18 AM, Djalal Harouni wrote:
>> Cc: Serge Hallyn <serge@...lyn.com>
>> Cc: Andy Lutomirski <luto@...nel.org>
>> Suggested-by: Rusty Russell <rusty@...tcorp.com.au>
>> Suggested-by: Kees Cook <keescook@...omium.org>
>> Signed-off-by: Djalal Harouni <tixxdz@...il.com>
>> ---
>> include/linux/kmod.h | 65 ++++++++++++++++++++++++++++++++++++++++++-----
>> include/linux/lsm_hooks.h | 6 ++++-
>> include/linux/security.h | 7 +++--
>> kernel/kmod.c | 29 ++++++++++++++++-----
>> security/security.c | 6 +++--
>> security/selinux/hooks.c | 3 ++-
>> 6 files changed, 97 insertions(+), 19 deletions(-)
>>
>> diff --git a/include/linux/kmod.h b/include/linux/kmod.h
>> index 40c89ad..ccd6a1c 100644
>> --- a/include/linux/kmod.h
>> +++ b/include/linux/kmod.h
>> @@ -33,16 +33,67 @@
>
>> +/**
>> + * request_module Try to load a kernel module
>> + *
>> + * Automatically loads the request module.
>> + *
>> + * @mod...: The module name
>> + */
>
> what are the "..." for? what do they do here?
Ok, will fix it.
>
>> +#define request_module(mod...) __request_module(true, -1, NULL, mod)
>> +
>> +#define request_module_nowait(mod...) __request_module(false, -1, NULL, mod)
>> +
>> +/**
>> + * request_module_cap Load kernel module only if the required capability is set
>> + *
[...]
>
>
> --
> ~Randy
Thank you very much for the review, will fix all.
--
tixxdz
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
