[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEiveUdj=PbJ6pGAX-wr3Fz+4=y6QbiDSE=mU6yKwxn11OU_gw@mail.gmail.com>
Date: Fri, 10 Nov 2017 11:32:55 +0100
From: Djalal Harouni <tixxdz@...il.com>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: Kees Cook <keescook@...omium.org>, Alexey Gladkov <gladkov.alexey@...il.com>,
Andy Lutomirski <luto@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>,
Linux FS Devel <linux-fsdevel@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>,
kernel-hardening@...ts.openwall.com,
LSM List <linux-security-module@...r.kernel.org>,
Linux API <linux-api@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Alexander Viro <viro@...iv.linux.org.uk>, Akinobu Mita <akinobu.mita@...il.com>,
"Tobin C. Harding" <me@...in.cc>, Oleg Nesterov <oleg@...hat.com>, Jeff Layton <jlayton@...chiereds.net>,
Ingo Molnar <mingo@...nel.org>, "Eric W. Biederman" <ebiederm@...ssion.com>,
Linus Torvalds <torvalds@...ux-foundation.org>, Daniel Micay <danielmicay@...il.com>,
Jonathan Corbet <corbet@....net>, "J. Bruce Fields" <bfields@...ldses.org>,
Stephen Rothwell <sfr@...b.auug.org.au>, Solar Designer <solar@...nwall.com>
Subject: Re: [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information
On Fri, Nov 10, 2017 at 11:26 AM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> On 11/9/17, Djalal Harouni <tixxdz@...il.com> wrote:
>
>> +struct proc_fs_info {
>> + struct pid_namespace *pid_ns;
>> +};
>
>> +static inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> +{
>> + return sb->s_fs_info;
>> +}
>
> Can you rename this to "struct proc_super_block *" then?
> That "info" suffix all over filesystems doesn't add much info itself
> just more typing.
> Ditto for "fs_info" identifiers.
Ok, will do.
>> +extern inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> { return NULL;}
>
> extern inline?
Oups, sorry will fix it and try to compile without proc.
Thank you!
--
tixxdz
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
